Skip to content

pytester: pop TOX_ENV_DIR from os.environ #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

pytester: pop TOX_ENV_DIR from os.environ #4382

merged 1 commit into from
Nov 13, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 13, 2018 •
edited
Loading

Closes: #4378
Fixes: #4366

No changelog, wasn't released yet, and only affects internal usage.

@blueyed blueyed mentioned this pull request Nov 13, 2018
Closed
RonnyPfannschmidt
RonnyPfannschmidt approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great start - as a followup we might want to investigate moving all the os.environ changes into monkeypatch calls

@blueyed blueyed merged commit a72eff5 into pytest-dev:features Nov 13, 2018
@blueyed blueyed deleted the pytester-pop-TOX_ENV_DIR branch November 13, 2018 11:42
@blueyed blueyed mentioned this pull request Nov 14, 2018
Closed
@bluetech bluetech mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @RonnyPfannschmidt