fix #4386 - handle uninitialized exceptioninfo in repr/str #4444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Nov 22, 2018
| print(repr(excinfo)) | ||
| import pprint | ||
|
|
||
| pprint.pprint(excinfo) |
There was a problem hiding this comment.
please add a comment explaining the strategy here
RonnyPfannschmidt
force-pushed
the
fix-4386-2
branch
from
c17d3ab to
b71bd9b
Compare
Codecov Report
@@ Coverage Diff @@
## master #4444 +/- ##
=========================================
+ Coverage 95.9% 95.9% +<.01%
=========================================
Files 111 111
Lines 25027 25042 +15
Branches 2442 2442
=========================================
+ Hits 24001 24016 +15
Misses 724 724
Partials 302 302
Continue to review full report at Codecov.
|
|
done |
As requested during review
RonnyPfannschmidt
changed the title
nicoddemus
approved these changes
Nov 22, 2018
|
The title still says "WIP", anything missing? |
RonnyPfannschmidt
changed the title
|
@nicoddemus thanks for picking it up 👍 |
asottile
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a backport of the fixing strategy from #4438