Skip to content

conftest: add uses_pexpect mark #5314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2019
Merged

conftest: add uses_pexpect mark #5314

merged 1 commit into from
May 28, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 27, 2019

Pulled out of #5313 - is this something we want to have?

@blueyed blueyed changed the title conftest: add uses_pexpect mark [RFC] conftest: add uses_pexpect mark May 27, 2019
blueyed
blueyed commented May 27, 2019
View reviewed changes
@blueyed
Copy link
Contributor Author

blueyed commented May 27, 2019

I think a generic feature like -k using_fixture(foo), or --using-fixture foo would be better.

@blueyed blueyed marked this pull request as ready for review May 27, 2019 18:11
nicoddemus
nicoddemus reviewed May 27, 2019
View reviewed changes
tox.ini
@@ -175,6 +175,7 @@ markers =
baz
# conftest.py reorders tests moving slow ones to the end of the list
slow
uses_pexpect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a quick description here 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is rather self-explaining, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done - also added a new "slowest_items" category.

@nicoddemus
Copy link
Member

--using-fixture foo would be better.

Yep, I've seen the need for this myself... should we open a new issue for it?

@blueyed
Copy link
Contributor Author

blueyed commented May 27, 2019

Yep, I've seen the need for this myself... should we open a new issue for it?

Yeah.

@blueyed blueyed changed the title [RFC] conftest: add uses_pexpect mark [RFC/WIP] conftest: add uses_pexpect mark May 27, 2019
@blueyed
Copy link
Contributor Author

blueyed commented May 27, 2019

Marking WIP to not merge it yet - there is no use for it currently really, given that we're likely to change the pexpect factor for CI (#5313, it would make sense to use -m uses_pexpect if jobs are being kept separate).

@blueyed blueyed changed the title [RFC/WIP] conftest: add uses_pexpect mark conftest: add uses_pexpect mark May 28, 2019
@blueyed blueyed mentioned this pull request May 28, 2019
Closed
@nicoddemus nicoddemus merged commit c35544a into pytest-dev:master May 28, 2019
@blueyed blueyed deleted the mark branch May 29, 2019 01:56
@pytest-dev pytest-dev deleted a comment from codecov bot Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @nicoddemus