Skip to content

Temporarily pin pluggy on master #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2019
Merged

Temporarily pin pluggy on master #5325

merged 1 commit into from
May 28, 2019

Conversation

asottile
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #5325 into master will increase coverage by 2.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5325      +/-   ##
==========================================
+ Coverage   89.13%   91.23%   +2.09%     
==========================================
  Files         115      115              
  Lines       26260    26260              
  Branches     2588     2588              
==========================================
+ Hits        23408    23957     +549     
+ Misses       2504     1971     -533     
+ Partials      348      332      -16
Impacted Files Coverage Δ
testing/test_terminal.py 90.2% <0%> (-7.94%) ⬇️
testing/python/integration.py 86.42% <0%> (-5%) ⬇️
testing/python/raises.py 90.54% <0%> (-4.06%) ⬇️
src/_pytest/terminal.py 92.05% <0%> (-0.98%) ⬇️
testing/python/collect.py 99.36% <0%> (+0.21%) ⬆️
src/_pytest/main.py 92.12% <0%> (+0.21%) ⬆️
src/_pytest/config/__init__.py 93.8% <0%> (+0.31%) ⬆️
src/_pytest/assertion/rewrite.py 95.5% <0%> (+0.48%) ⬆️
src/_pytest/fixtures.py 97.93% <0%> (+0.68%) ⬆️
src/_pytest/nodes.py 95.58% <0%> (+1.47%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce4505...2e2e895. Read the comment docs.

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we also appear to have new / flaky failures on features..?!

@asottile
Copy link
Member Author

But we also appear to have new / flaky failures on features..?!

link? I haven't seen any

@blueyed
Copy link
Contributor

blueyed commented May 28, 2019

Only https://travis-ci.org/pytest-dev/pytest/builds/537992776 apparently (via https://travis-ci.org/pytest-dev/pytest/branches). That is the pypy3-spamming one, so might be unrelated then.

:shipit:

@asottile
Copy link
Member Author

we'll need to make sure to revert this on features when we merge the two

@asottile asottile merged commit 81cc731 into pytest-dev:master May 28, 2019
@asottile asottile deleted the temporary branch May 28, 2019 16:37
@nicoddemus
Copy link
Member

Thanks @asottile!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants