Skip to content

Fix pexpect tests on MacOS #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2019
Merged

Fix pexpect tests on MacOS #5336

merged 4 commits into from
May 30, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 29, 2019

No description provided.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #5336 into master will increase coverage by 6.65%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5336      +/-   ##
==========================================
+ Coverage    87.6%   94.25%   +6.65%     
==========================================
  Files         115      115              
  Lines       26280    26278       -2     
  Branches     2590     2589       -1     
==========================================
+ Hits        23023    24769    +1746     
+ Misses       2913     1195    -1718     
+ Partials      344      314      -30
Impacted Files Coverage Δ
testing/test_pdb.py 99.21% <100%> (+53.88%) ⬆️
src/_pytest/terminal.py 93.44% <0%> (+0.41%) ⬆️
src/_pytest/nodes.py 94.6% <0%> (+0.49%) ⬆️
src/_pytest/fixtures.py 97.93% <0%> (+0.55%) ⬆️
src/_pytest/config/__init__.py 94.44% <0%> (+0.63%) ⬆️
src/_pytest/unittest.py 94.21% <0%> (+1.05%) ⬆️
src/_pytest/outcomes.py 96.15% <0%> (+1.28%) ⬆️
testing/test_assertrewrite.py 84.06% <0%> (+1.46%) ⬆️
testing/test_tmpdir.py 98.92% <0%> (+1.61%) ⬆️
testing/test_terminal.py 99.53% <0%> (+1.71%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a4a13...6896dbc. Read the comment docs.

@blueyed blueyed changed the title WIP: fix pexpect tests on MacOS Fix pexpect tests on MacOS May 30, 2019
@blueyed
Copy link
Contributor Author

blueyed commented May 30, 2019

Should be good now, assuming that CI is green.

Uses `PYTEST_COVERAGE=1` already, which will come in via dropping
Python 2 soon anyway.
@blueyed blueyed merged commit 72fc439 into pytest-dev:master May 30, 2019
@blueyed blueyed deleted the fix-pexpect branch May 30, 2019 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants