Skip to content

[4.6] Backport unwrapper PR #5453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Jun 16, 2019

Following up #5404.

@blueyed
Copy link
Contributor

blueyed commented Jun 16, 2019

Fails on py27:

E AttributeError: 'module' object has no attribute 'unwrap'

@Zac-HD Zac-HD force-pushed the backport-unwrapper branch from 5cf0cb5 to 51cef39 Compare June 17, 2019 04:43
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #5453 into 4.6-maintenance will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           4.6-maintenance    #5453      +/-   ##
===================================================
+ Coverage            95.91%   96.18%   +0.27%     
===================================================
  Files                  115      115              
  Lines                26407    26429      +22     
  Branches              2609     2610       +1     
===================================================
+ Hits                 25328    25421      +93     
+ Misses                 755      703      -52     
+ Partials               324      305      -19
Impacted Files Coverage Δ
testing/test_doctest.py 100% <100%> (ø) ⬆️
src/_pytest/doctest.py 96.85% <100%> (+0.42%) ⬆️
src/_pytest/fixtures.py 97.55% <0%> (+0.27%) ⬆️
testing/test_capture.py 99.25% <0%> (+0.29%) ⬆️
testing/test_terminal.py 99.84% <0%> (+0.31%) ⬆️
testing/test_config.py 99.83% <0%> (+0.33%) ⬆️
testing/test_pdb.py 99.22% <0%> (+0.38%) ⬆️
src/_pytest/pytester.py 91.66% <0%> (+0.42%) ⬆️
src/_pytest/assertion/rewrite.py 95.77% <0%> (+0.48%) ⬆️
testing/python/fixtures.py 99.09% <0%> (+0.56%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c1a04...443af11. Read the comment docs.

@Zac-HD Zac-HD force-pushed the backport-unwrapper branch from 51cef39 to 443af11 Compare June 17, 2019 04:48
@Zac-HD Zac-HD merged commit c765b83 into pytest-dev:4.6-maintenance Jun 17, 2019
@Zac-HD Zac-HD deleted the backport-unwrapper branch June 17, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants