Skip to content

[4.6] Handle only known functions in rm_rf (#5627) #5691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Aug 3, 2019

Backport of #5627

Conflicts:

  • src/_pytest/pathlib.py

Also had to adapt:

  • PermissionError into OSError with appropriate errno
  • Change keyword-only argument to **kwargs
  • Remove type annotations

Backport of pytest-dev#5627

Conflicts:
- 	src/_pytest/pathlib.py

Also had to adapt:

- PermissionError into OSError with appropriate
- Change keyword-only argument to **kwargs
- Remove type annotations
@nicoddemus nicoddemus requested a review from blueyed August 3, 2019 13:52
@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #5691 into 4.6-maintenance will increase coverage by 24.96%.
The diff coverage is 98.43%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           4.6-maintenance    #5691       +/-   ##
====================================================
+ Coverage            71.23%   96.19%   +24.96%     
====================================================
  Files                  115      115               
  Lines                26512    26542       +30     
  Branches              2613     2615        +2     
====================================================
+ Hits                 18886    25533     +6647     
+ Misses                7166      703     -6463     
+ Partials               460      306      -154
Impacted Files Coverage Δ
testing/test_tmpdir.py 99.14% <100%> (+22.73%) ⬆️
src/_pytest/pathlib.py 91.26% <96%> (+10.35%) ⬆️
src/_pytest/assertion/rewrite.py 95.77% <0%> (+0.81%) ⬆️
testing/test_stepwise.py 100% <0%> (+1.35%) ⬆️
src/_pytest/_code/source.py 91.58% <0%> (+2.33%) ⬆️
src/_pytest/fixtures.py 97.55% <0%> (+2.44%) ⬆️
src/_pytest/_code/code.py 95.5% <0%> (+2.56%) ⬆️
src/_pytest/terminal.py 93.44% <0%> (+2.64%) ⬆️
src/_pytest/mark/__init__.py 97.61% <0%> (+3.57%) ⬆️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 829941a...0274c08. Read the comment docs.

@asottile asottile merged commit a19ae2a into pytest-dev:4.6-maintenance Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants