Skip to content

test_non_ascii_paste_text: mock call to urlopen #5728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 10, 2019

@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #5728 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5728      +/-   ##
==========================================
- Coverage   96.17%   96.16%   -0.01%     
==========================================
  Files         117      117              
  Lines       25864    25865       +1     
  Branches     2498     2498              
==========================================
- Hits        24875    24874       -1     
- Misses        689      690       +1     
- Partials      300      301       +1
Impacted Files Coverage Δ
testing/test_pastebin.py 100% <100%> (ø) ⬆️
src/_pytest/pastebin.py 87.71% <0%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77c83a...0db9dad. Read the comment docs.

@blueyed blueyed requested a review from nicoddemus August 10, 2019 22:36
@blueyed
Copy link
Contributor Author

blueyed commented Aug 11, 2019

@nicoddemus
I've requested your review here since the test is from you.

@nicoddemus
Copy link
Member

Thanks!

@nicoddemus nicoddemus merged commit a295a3d into pytest-dev:master Aug 12, 2019
@blueyed blueyed deleted the test_non_ascii_paste_text branch August 12, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants