Skip to content

pytester: spawn: skip without pexpect.spawn #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 13, 2019

"pexpect" can be imported on Windows, but does not have "pexpect.spawn"
then.

Ref: https://github.com/pexpect/pexpect/blob/a803933ed53/pexpect/__init__.py#L73-L76

blueyed added a commit to pdbpp/pdbpp that referenced this pull request Aug 13, 2019
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #5736 into features will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5736      +/-   ##
============================================
- Coverage     96.26%   96.25%   -0.01%     
============================================
  Files           117      117              
  Lines         25900    25902       +2     
  Branches       2494     2495       +1     
============================================
  Hits          24932    24932              
- Misses          665      666       +1     
- Partials        303      304       +1
Impacted Files Coverage Δ
src/_pytest/pytester.py 90.8% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24132d...1434b66. Read the comment docs.

@nicoddemus
Copy link
Member

Thanks!

@nicoddemus nicoddemus merged commit fa75d81 into pytest-dev:features Aug 14, 2019
@blueyed blueyed deleted the pexpect-spawn-skip branch August 14, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants