Skip to content

test_assertion_location #5755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2019
Merged

test_assertion_location #5755

merged 2 commits into from
Aug 17, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 17, 2019

Ref: #5754

@blueyed
Copy link
Contributor Author

blueyed commented Aug 17, 2019

Failed as expected under coverage: https://travis-ci.org/pytest-dev/pytest/jobs/573192533#L786

/cc @nedbat @asottile
Any idea what is happening here?

@blueyed blueyed force-pushed the fix-assert-location-with-coverage branch from a07fd95 to 4782a18 Compare August 17, 2019 19:28
@blueyed blueyed force-pushed the fix-assert-location-with-coverage branch from 4782a18 to 05bfe73 Compare August 17, 2019 19:34
asottile
asottile approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile
Copy link
Member

since it's global, all asserts will share those ast instances (with last-one-wins positioning information) -- not sure why coverage changes it though 🤔

patch looks good though 👍

@blueyed
Copy link
Contributor Author

blueyed commented Aug 17, 2019

@asottile
Thanks!

@nedbat
Still interested in your input - might also indicate some bug / issue with Coverage.py after all.

@blueyed blueyed merged commit 32dac18 into pytest-dev:master Aug 17, 2019
@blueyed blueyed deleted the fix-assert-location-with-coverage branch August 17, 2019 20:49
@blueyed blueyed mentioned this pull request Aug 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @asottile