Skip to content

[4.6] Publish GitHub release notes after deployment #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicoddemus
Copy link
Member

Backport of the following PRs: #5723, #5740, and #5750.

nicoddemus and others added 4 commits August 19, 2019 16:38
Publish GitHub release notes after deployment
Use TRAVIS_REPO_SLUG instead of hard-coding pytest-dev/pytest
Forward $TRAVIS_REPO_SLUG for GH publish notes
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #5767 into 4.6-maintenance will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           4.6-maintenance    #5767      +/-   ##
===================================================
+ Coverage            95.92%   96.17%   +0.24%     
===================================================
  Files                  115      115              
  Lines                26553    26553              
  Branches              2615     2615              
===================================================
+ Hits                 25472    25537      +65     
+ Misses                 755      710      -45     
+ Partials               326      306      -20
Impacted Files Coverage Δ
src/_pytest/unittest.py 93.22% <0%> (-1.05%) ⬇️
testing/test_pdb.py 99.02% <0%> (+0.19%) ⬆️
src/_pytest/fixtures.py 97.55% <0%> (+0.27%) ⬆️
testing/test_capture.py 99.25% <0%> (+0.29%) ⬆️
testing/test_terminal.py 99.84% <0%> (+0.31%) ⬆️
testing/test_config.py 99.83% <0%> (+0.32%) ⬆️
src/_pytest/pytester.py 91.66% <0%> (+0.42%) ⬆️
src/_pytest/assertion/rewrite.py 95.77% <0%> (+0.48%) ⬆️
testing/python/fixtures.py 99.09% <0%> (+0.56%) ⬆️
src/_pytest/junitxml.py 95.9% <0%> (+0.58%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b039b1...9191857. Read the comment docs.

Avoid upgrading pip because it is giving this error on py34:

Requirement already up-to-date: pip in c:\hostedtoolcache\windows\python\3.4.4\x64\lib\site-packages (19.2.1)
ERROR: Package 'pip' requires a different Python: 3.4.4 not in '>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*'
[error]Cmd.exe exited with code '1'.
@nicoddemus
Copy link
Member Author

Had to stop upgrading pip due to it failing on py34 (9191857):

Requirement already up-to-date: pip in c:\hostedtoolcache\windows\python\3.4.4\x64\lib\site-packages (19.2.1)
ERROR: Package 'pip' requires a different Python: 3.4.4 not in '>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*'
[error]Cmd.exe exited with code '1'.

Link: https://pytest-dev.visualstudio.com/pytest/_build/results?buildId=2062

@nicoddemus
Copy link
Member Author

nicoddemus commented Aug 20, 2019

Travis failed due to coverage being down.

Because Travis passed in the previous commit, and the last commit only touched azure-pipelines.yaml I'm assuming this is temporary so I'm going ahead with the merge.

@nicoddemus nicoddemus merged commit 117f52d into pytest-dev:4.6-maintenance Aug 20, 2019
@nicoddemus nicoddemus deleted the backport-5723-5740-5750 branch August 20, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant