-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
2/X Fix check_untyped_defs = True mypy errors #5847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9f60955
to
e399e72
Compare
The CI failed two times with
coming from pytest/scripts/report-coverage.sh Line 16 in c8cf748
I don't think it is related to the changes. |
0df3898
to
37e0b7a
Compare
37e0b7a
to
6715759
Compare
Note that mypy 0.740 substantially improved Could you check how things look with pytest and whether you're still willing to invest the effort to get it clean of errors? |
6715759
to
c1fb774
Compare
I tried 0.740 on pytest now -- it adds a dozen unrelated errors, and only a few new
Sure. I am trying to keep the PRs reasonably small, and only have one in-flight PR at a time, to not overwhelm anyone. However, there doesn't seem to be any volunteers to review these changes (understandably), so it's going to take a while. BTW, I rebased this PR now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can be changed after mypy v0.740 is merged.
And see #6039.
In order to make the LiteralOutputChecker lazy initialization more amenable to type checking, I changed it to match the scheme already used in this file to lazy-initialize PytestDoctestRunner.
c1fb774
to
1787bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes for some more
check_untyped_defs
errors from mypy.The first commit required a small refactoring (see commit message).
Continuation of #5673.