Skip to content

2/X Fix check_untyped_defs = True mypy errors #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 23, 2019

Conversation

bluetech
Copy link
Member

Fixes for some more check_untyped_defs errors from mypy.

The first commit required a small refactoring (see commit message).

Continuation of #5673.

@bluetech bluetech force-pushed the type-annotations-4 branch 2 times, most recently from 9f60955 to e399e72 Compare September 20, 2019 12:33
@bluetech
Copy link
Member Author

The CI failed two times with

+ bash /dev/fd/63 -Z -X gcov -X coveragepy -X search -X xcode -X gcovout -X fix -f coverage.xml
++ curl -s https://codecov.io/bash
bash: /dev/fd/63: No such file or directory

coming from

bash <(curl -s https://codecov.io/bash) -Z -X gcov -X coveragepy -X search -X xcode -X gcovout -X fix -f coverage.xml

I don't think it is related to the changes.

@bluetech bluetech force-pushed the type-annotations-4 branch 2 times, most recently from 0df3898 to 37e0b7a Compare September 25, 2019 19:13
@blueyed blueyed closed this Oct 14, 2019
@blueyed blueyed reopened this Oct 14, 2019
@The-Compiler
Copy link
Member

Note that mypy 0.740 substantially improved check_untyped_defs - in my project, I got 469 new errors 😆

Could you check how things look with pytest and whether you're still willing to invest the effort to get it clean of errors?

@bluetech
Copy link
Member Author

Could you check how things look with pytest

I tried 0.740 on pytest now -- it adds a dozen unrelated errors, and only a few new check_untyped_defs errors. So not too worrisome. I'll send a PR to update to 0.740 now (hopefully).

and whether you're still willing to invest the effort to get it clean of errors?

Sure. I am trying to keep the PRs reasonably small, and only have one in-flight PR at a time, to not overwhelm anyone. However, there doesn't seem to be any volunteers to review these changes (understandably), so it's going to take a while.

BTW, I rebased this PR now.

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be changed after mypy v0.740 is merged.
And see #6039.

@bluetech bluetech requested a review from blueyed October 23, 2019 12:34
Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluetech bluetech merged commit 7a2d2d8 into pytest-dev:features Oct 23, 2019
@bluetech bluetech deleted the type-annotations-4 branch October 23, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants