ci: test oldest supported attrs #5922
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
added
the
type: infrastructure
blueyed
changed the title
blueyed
commented
Oct 6, 2019
| @@ -41,6 +41,8 @@ setenv = | |||
| xdist: _PYTEST_TOX_POSARGS_XDIST=-n auto | |||
| extras = testing | |||
| deps = | |||
| oldattrs: attrs==17.4.0 | |||
| oldattrs: hypothesis<=4.38.1 | |||
There was a problem hiding this comment.
hypothesis 4.38.2 bumped the attrs requirement itself.
|
I think we should instead |
That's arguable, but neverthless it doesn't discard this PR, we don't know when Back to the point, not sure we should require attrs>=19.2: we are an upstream library which is loaded into the user's runtime, so we should be careful when to bump our minimal requirements, specially for a widely used library such as Given that so far this is the only issue that has bitten us, I would leave it alone. If more issues start to creep in, we should definitely reconsider this though. |
nicoddemus
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.