Skip to content

[WIP] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[WIP] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds #5962

wants to merge 4 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 15, 2019

Delays notification (and hopefully status) until CI has passed.

@blueyed
[WIP] ci: codecov: require_ci_to_pass: yes
06534d7 
Delays notification (and hopefully status) until CI has passed.
@blueyed
Copy link
Contributor Author

blueyed commented Oct 15, 2019 •
edited
Loading

Should be the default already..
But e.g. with #5961 it reports a status while Azure is not finished (but appears to be hanging in some way - no "Details" link there).

Via #5959 (where Travis was also not finished) - contacted @codecov support.
2019-10-15-031009_708x603_escrotum

@pytest-dev pytest-dev deleted a comment from codecov bot Oct 15, 2019
@blueyed blueyed changed the title [WIP] ci: codecov: require_ci_to_pass: yes [W I P] ci: codecov: require_ci_to_pass: yes Oct 15, 2019
@blueyed blueyed changed the title [W I P] ci: codecov: require_ci_to_pass: yes [W I P] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds Oct 15, 2019
@nicoddemus nicoddemus changed the title [W I P] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds [WIP] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds Oct 15, 2019
@nicoddemus
Copy link
Member

Did you use [W I P] here on purpose so CI would finish?

@blueyed
Copy link
Contributor Author

blueyed commented Oct 15, 2019

Did you use [W I P] here on purpose so CI would finish?

More to get a final status (it is a bit annoying that WIP makes it orange).

@blueyed blueyed closed this Oct 16, 2019
@blueyed blueyed deleted the codecov-require_ci_to_pass branch October 16, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @nicoddemus