Skip to content

pytester: typing #6025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

pytester: typing #6025

merged 1 commit into from
Oct 28, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 21, 2019 •
edited
Loading

No description provided.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 23, 2019

Backed out to use Union[int, ExitCode].

@blueyed blueyed force-pushed the pytester-typing branch 2 times, most recently from eb02cc3 to 163cf19 Compare October 23, 2019 09:38
bluetech
bluetech approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some optional comments.

@blueyed blueyed force-pushed the pytester-typing branch 2 times, most recently from bf4c45d to e86ebeb Compare October 23, 2019 17:56
blueyed
blueyed commented Oct 23, 2019
View reviewed changes
bluetech
bluetech approved these changes Oct 23, 2019
View reviewed changes
@blueyed blueyed force-pushed the pytester-typing branch 2 times, most recently from bf454b1 to 058ca23 Compare October 27, 2019 00:55
@blueyed blueyed merged commit ec27363 into pytest-dev:features Oct 28, 2019
@blueyed blueyed deleted the pytester-typing branch October 28, 2019 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @bluetech