Skip to content

Preparing release version 5.3.1 #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

nicoddemus
Copy link
Member

No description provided.


No significant changes.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is "duplicated".
Would be better to do this after #6272 also, which improves the existing snippets already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus
Although #6272 is approved, I do not want to create a conflict here by merging it myself.
So please feel free to merge #6272 yourself if you think it is good either before, or after (but needs conflict resolution then - iff the improved changelogs make sense; I've merely done it to show what can be done there).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will fix the conflicts after merging this one. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I will only be able to get to this much later though, so feel free to get at it if you want/can).

@nicoddemus nicoddemus merged commit 8b8cba3 into pytest-dev:master Nov 26, 2019
@nicoddemus nicoddemus deleted the release-5.3.1 branch November 26, 2019 14:56
@hugovk
Copy link
Member

hugovk commented Nov 26, 2019

Minor thing at https://github.com/pytest-dev/pytest/releases/tag/5.3.1, the newlines are a bit off:


image


Looks well justified in edit mode, but much of the markup isn't visible in the rendered version:


image


@nicoddemus
Copy link
Member Author

@hugovk fixed, thanks!

@blueyed
Copy link
Contributor

blueyed commented Nov 26, 2019

the newlines are a bit off:

This applies to older releases also: https://github.com/pytest-dev/pytest/releases
towncrier config issue?

@nicoddemus
Copy link
Member Author

This applies to older releases also: pytest-dev/pytest/releases
towncrier config issue?

I think the problem is that technically Markdown ignores line-breaks inside paragraphs, but GitHub honours them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants