-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Preparing release version 5.3.1 #6277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9525ad6
to
05008f6
Compare
|
||
No significant changes. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is "duplicated".
Would be better to do this after #6272 also, which improves the existing snippets already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicoddemus
Although #6272 is approved, I do not want to create a conflict here by merging it myself.
So please feel free to merge #6272 yourself if you think it is good either before, or after (but needs conflict resolution then - iff the improved changelogs make sense; I've merely done it to show what can be done there).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will fix the conflicts after merging this one. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I will only be able to get to this much later though, so feel free to get at it if you want/can).
Minor thing at https://github.com/pytest-dev/pytest/releases/tag/5.3.1, the newlines are a bit off: Looks well justified in edit mode, but much of the markup isn't visible in the rendered version: |
@hugovk fixed, thanks! |
This applies to older releases also: https://github.com/pytest-dev/pytest/releases |
I think the problem is that technically Markdown ignores line-breaks inside paragraphs, but GitHub honours them. |
No description provided.