Skip to content

Update py27/py34 deprecation docs #6401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2020

Conversation

nicoddemus
Copy link
Member

I've updated the text and incorporated the topics from #5275, so this
can now be part of the official docs, and #5275 can be closed/unpinned.

Closes #5275

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great update, this nicely elaborates the stance we agreed on before and communicates it to the users/affected parties

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one character, otherwise looks good 👍

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions

@nicoddemus nicoddemus force-pushed the 4.6-maintenance-docs-onward branch from a2b2798 to 4037468 Compare January 4, 2020 20:46
I've updated the text and incorporated the topics from pytest-dev#5275, so this
can now be part of the official docs, and pytest-dev#5275 can be closed/unpinned.

Closes pytest-dev#5275
@nicoddemus nicoddemus force-pushed the 4.6-maintenance-docs-onward branch from 4037468 to 4fa819e Compare January 4, 2020 20:52
@nicoddemus
Copy link
Member Author

nicoddemus commented Jan 4, 2020

Thanks @hugovk, done all.

Appreciate the reviews!

@asottile asottile merged commit 26a2e1a into pytest-dev:master Jan 4, 2020
@nicoddemus nicoddemus deleted the 4.6-maintenance-docs-onward branch January 4, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Technical aspects related to Python 2.7 and 3.4 support (pytest 5.0)
4 participants