Clear node collection cache after collection is done #6491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
suggested changes
Jan 17, 2020
I find it makes the intent of the cache clearer (only meant to use during collection); unless you are against it I would like to keep it. I will add the type hints, thanks. 👍 |
nicoddemus
force-pushed
the
clear-node-collection-cache
branch
from
284f5b6 to
7d09db9
Compare
blueyed
reviewed
Jan 17, 2020
nicoddemus
force-pushed
the
clear-node-collection-cache
branch
from
7d09db9 to
f84157e
Compare
|
Done, thanks for the pointers! Had to add a few more type hints and also applied the same logic to the old I want to eventually refactor the entire logic out of the |
bluetech
approved these changes
Jan 21, 2020
Also rename the involved variables to convey its intent better and add type hints
nicoddemus
force-pushed
the
clear-node-collection-cache
branch
from
f84157e to
7b1e3d1
Compare
The latter. 😁 |
|
Rebased this on features too, as it should be. |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 21, 2020
Pulled out of pytest-dev#6491.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 21, 2020
Pulled out of pytest-dev#6491.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 22, 2020
Pulled out of pytest-dev#6491.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename the variable to convey its intent better