Type annotate some hookspecs & impls #6725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
commented
Feb 13, 2020
| def pytest_configure(config): | ||
| config.cache = Cache.for_config(config) | ||
| def pytest_configure(config: Config) -> None: | ||
| # Type ignored: pending mechanism to store typed objects scoped to config. |
There was a problem hiding this comment.
This repeats in several plugins. I have a simple plan for how to do it, but for now I added type-ignores.
| @@ -510,13 +512,13 @@ def __init__(self, config): | |||
| ) | |||
|
|
|||
| log_file = get_option_ini(config, "log_file") | |||
| if log_file: | |||
| if not log_file: | |||
There was a problem hiding this comment.
Swapped the order so mypy can infer the type without an annotation.
blueyed
reviewed
Feb 21, 2020
Annotate some "easy" arguments of hooks that repeat in a lot of internal plugins. Not all of the arguments are annotated fully for now.
bluetech
force-pushed
the
hooks-annotate-1
branch
from
3b91b84 to
190e01c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #6717.
Annotate some "easy" arguments of hooks that repeat in a lot of internal plugins.
Not all of the arguments are annotated fully for now.