Move _collectfile to FSCollector #6830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was implemented both on `Session` and `Package`, where the extra code in `Package._collectfile` was not covered/used.
blueyed
referenced
this pull request
Feb 27, 2020
|
The extra code if I see correctly is this: if self.fspath == path: # __init__.py
return [self]Did you investigate why it was added and why it's not used? |
|
@bluetech good call. #4319 was WIP when it was merged, and a6ff5e6 is from its cleanup: #4369. Codecov reported it there already, but it was missed / not looked at: https://codecov.io/gh/pytest-dev/pytest/compare/7ab3d818f03331ebf2765f6c4ea005b721b1c3fe...a6ff5e6bfc117f9151c6506a5f6f4bba51a1676c/changes |
bluetech
approved these changes
Feb 29, 2020
aklajnert
pushed a commit
to aklajnert/pytest
that referenced
this pull request
Feb 29, 2020
Previously this was implemented both on `Session` and `Package`, where the extra code in `Package._collectfile` was not covered/used. Ref: pytest-dev#6830 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was implemented both on
SessionandPackage, wherethe extra code in
Package._collectfilewas not covered/used.