mark: expose Mark, MarkDecorator, MarkGenerator under pytest for typing purposes #8179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type cannot be constructed directly, but is exported for use in type annotations, since it is reachable through existing public API.
The type cannot be constructed directly, but is exported for use in type annotations, since it is reachable through existing public API.
The type cannot be constructed directly, but is exported for use in type annotations, since it is reachable through existing public API.
| _param_ids_generated = attr.ib( | ||
| type=Optional[Sequence[str]], default=None, repr=False | ||
| ) | ||
| _param_ids_generated: Optional[Sequence[str]] = attr.ib(default=None, repr=False) |
There was a problem hiding this comment.
should we introduce a metaclass that mangles the _ispytest in __call__ - making all those classes have strange ctors is a pain
There was a problem hiding this comment.
IMHO I prefer the _is_pytest approach because it is more explicit... I think a metaclass introduces needless complexity just for this change.
Just stating my opinion though, not against changing it to a metaclass if Ran also prefers to do so.
There was a problem hiding this comment.
I feel simillary to @nicoddemus, I think that while the _ispytest is a bit annoying, it is better in most other dimensions (like ease of understanding, greppability, ease of type checking, ease of bypassing when needed), so I prefer it.
nicoddemus
approved these changes
Dec 20, 2020
| @@ -465,9 +488,6 @@ def test_function(): | |||
| applies a 'slowtest' :class:`Mark` on ``test_function``. | |||
| """ | |||
|
|
|||
| _config: Optional[Config] = None | |||
| _markers: Set[str] = set() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #7469, please see details there. Similar to previous PR #8017 that went in 6.1; haven't seen any complaints about it yet.