Add new testdirs ini option #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, just one consideration: We might consider specifying wildcarded paths in the future such as "tests//test*.py or "app//tests/test*.py" in which case it might be better to name the ini option "testpaths" instead of "testdirs". |
| [pytest] | ||
| norecursedirs = .svn _build tmp* | ||
|
|
||
| This would tell ``pytest`` to not look into typical subversion or | ||
| sphinx-build directories or into any ``tmp`` prefixed directory. | ||
|
|
||
| .. confval:: testdirs | ||
|
|
There was a problem hiding this comment.
Check if we can add .. versionadded:: here
Good point, I will change it later. 😄 |
nicoddemus
force-pushed
the
testdirs-option
branch
from
4c7d4c3 to
53884a3
Compare
|
@hpk42 changed to |
nicoddemus
force-pushed
the
testdirs-option
branch
2 times, most recently
from
a09affe to
aef416c
Compare
| if os.getcwd() == self.rootdir: | ||
| args = self.getini('testpaths') | ||
| if not args: | ||
| args = [os.getcwd()] | ||
| self.args = args |
There was a problem hiding this comment.
minor nit. os.getcwd() should be assigned to a var and then this var used instead of potentially calling it twice IMHO.
nicoddemus
force-pushed
the
testdirs-option
branch
2 times, most recently
from
c37310e to
870f6fa
Compare
nicoddemus
force-pushed
the
testdirs-option
branch
from
870f6fa to
854e603
Compare
|
Rebased on master to account for the mock fix for py26. |
nicoddemus
added a commit
that referenced
this pull request
Jul 11, 2015
Add new testdirs ini option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #694, but not exactly as described in there. Usually projects have a well defined location for tests (pytest for example is
testing), so an option to specify which directories to look for tests when executing pytest without arguments from the root directory seems useful.