Issue #8823 - remove bots from contributors list #8828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Jun 30, 2021
scripts/release.py
Outdated
| @@ -22,6 +22,11 @@ def announce(version): | |||
|
|
|||
| contributors = set(stdout.splitlines()) | |||
|
|
|||
| # remove strings within contributors that have substring "[bot]" | |||
| for name in contributors: | |||
There was a problem hiding this comment.
Suggested change
| for name in contributors: | |
| for name in list(contributors): |
Otherwise we will change the size of the set during iteration and raise an error.
There was a problem hiding this comment.
But probably it is easier to update line 23 to:
contributors = set(x for x in stdout.splitlines() if "[bot]" not in x)There was a problem hiding this comment.
Yeah I agree. I think the one-liner works well and looks nicer. Should I make a new commit?
There was a problem hiding this comment.
We typically squash PRs into a single commit when merging, so feel free to just push a second commit to the same branch (which will automatically update the PR).
As an aside, I'd probably use name instead of x, and if not name.endswith("[bot]") as I think it's always used as a suffix.
for more information, see https://pre-commit.ci
The-Compiler
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.