Remove branch restriction to allow testing feature branches #9467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Jan 1, 2022
| @@ -3,8 +3,6 @@ name: main | |||
| on: | |||
| push: | |||
| branches: | |||
There was a problem hiding this comment.
i presume we need the branches key?
There was a problem hiding this comment.
I think so, because there's a tags sibling key too. But irrelevant now because we're allowing "test-me-*" instead :)
asottile
requested changes
Jan 1, 2022
.github/workflows/main.yml
Outdated
Comment on lines
6
to
7
| - main | ||
| - "[0-9]+.[0-9]+.x" |
There was a problem hiding this comment.
this is intentional to prevent double-testing branches -- my recommendation is to instead add another prefix such as what I do here
There was a problem hiding this comment.
I agree, this would be rather wasteful - instead of running CI twice for each change (PR + main), it will be run 3 times (branch + PR + main). I think that for local testing, @asottile's suggestion or a local PR would do.
There was a problem hiding this comment.
Sounds good, updated with test-me-*!
hugovk
force-pushed
the
ci-rm-feature-branch-restriction
branch
from
a3385b6 to
819c67f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #9461 (comment):
Allow the CI to test feature branches on forks, so contributors can check their branch passes the CI before creating a PR.