Paths after normal options are now properly used to discover rootdir and ini files

[nicoddemus]

Fix #949

[nicoddemus]

This case and the next would fail before this patch, with rootdir being set to myroot/dir1 and myroot/dir2 respectively (effectively ignoring the 3rd argument when determining rootdir).

[RonnyPfannschmidt]

looks good to me, but i'd like someone else to review as well

[bubenkoff]

please assert which root is actually set, not only that it's found at all

[nicoddemus]

Thanks for the feedback!

But what do you mean "is actually set"? If the pytest headers show rootdir: /path/to/folder, doesn't that mean that path/to/folder is already set as rootdir? Or do you mean something else?

[bubenkoff]

exactly, but result.stdout.fnmatch_lines(['*rootdir: *myroot, inifile: ']) only asserts that myroot is choosen, and actually both dir1 and dir2 are subfolders of that root
but what if i put folders which are not children of the same folder?

[nicoddemus]

Hmmm I see.

But the point of the test was to make sure if you inserted other options in the middle of the paths, the paths to the right should still be considered to determine the rootdir. What you are asking seems to be to test the normal semantics for rootdir, which is already tested down the file (in the TestRootdir class). Or am I missing something?

[bubenkoff]

yep, thanks makes sense then
ok, then im fine with merging, should i do it or Ronny?

On Wed, Aug 26, 2015 at 5:42 PM Bruno Oliveira [email protected]
wrote:

In testing/test_config.py
#961 (comment):

+def test_consider_args_after_options_for_rootdir_and_inifile(testdir, args):

• """
• Consider all arguments in the command-line for rootdir and inifile
• discovery, even if they happen to occur after an option. Mixing relative and absolute paths to tests fails pytest.ini lookup #949
• """

• replace "dir1" and "dir2" from "args" into their real directory

• root = testdir.tmpdir.mkdir('myroot')
• d1 = root.mkdir('dir1')
• d2 = root.mkdir('dir2')
• for i, arg in enumerate(args):

•    if arg == 'dir1':
  

•        args[i] = d1
  

•    elif arg == 'dir2':
  

•        args[i] = d2
  

• result = testdir.runpytest(*args)
• result.stdout.fnmatch_lines(['*rootdir: *myroot, inifile: '])

Hmmm I see.

But the point of the test was to make sure if you inserted other options
in the middle of the paths, the paths to the right should still be
considered to determine the rootdir. What you are asking seems to be to
test the normal semantics for rootdir, which is already tested down the
file (in the TestRootdir class). Or am I missing something?

—
Reply to this email directly or view it on GitHub
https://github.com/pytest-dev/pytest/pull/961/files#r37997786.

[nicoddemus]

I think @RonnyPfannschmidt said the patch seemed OK, so feel free to merge. 😄

[nicoddemus]

Went ahead and did it myself, as I noticed you replied by email and might be on the run.

Thanks!

[bubenkoff]

one comment