Add deserialization to price messages #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
requested review from
guibescos,
jayantk and
Reisen
and removed request for
guibescos and
jayantk
jayantk
previously approved these changes
May 24, 2023
guibescos
previously approved these changes
May 24, 2023
cctdaniel
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deserialization to PriceFeedMessage and TwapMessage. It also introduces a Message enum which wraps messages. I have refactored the code such as renaming
as_bytestoto_bytesbecauseas_bytesusually returns a reference from a type that is wrapping bytes.The purpose of this change is to use these structs from this crate (as library) in hermes.