feat: Support Sui Price Update with Coin Input #2861
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
| const packageId = await this.getPythPackageId(); | ||
|
|
||
| packageId: string, | ||
| ): Promise<any> { |
There was a problem hiding this comment.
please don't use any. if the type is not known and you can extract it later use unknown
| @@ -6,6 +6,10 @@ import { HexString } from "@pythnetwork/price-service-client"; | |||
| import { Buffer } from "buffer"; | |||
|
|
|||
| const MAX_ARGUMENT_SIZE = 16 * 1024; | |||
| type Coin = { | |||
There was a problem hiding this comment.
i wonder whether they had a type for this themselves.
There was a problem hiding this comment.
Yeah I couldn't find one myself. Their TS docs use the splitCoins function but they never provide an example of what explicit type it is. In their github repo, they have that function return this type: Extract<Argument, { Result: unknown }> & Extract<Argument, { NestedResult: unknown }>[]
In any case, I figured why not just use the type the IDE supplies me.
There was a problem hiding this comment.
So there is a TransactionResult type which almost matches this. But we seem to explicitly use the nestedResult version. So I just redefined it and use that. We can use the SDK type if we dont do [hotPotato] and such but I dont know what that would do and don't want to change things so drastically right now.
Summary
Adds a new SDK function which takes coins as a function argument. This allows the price update calls to work without accessing the TX gas.
Rationale
Request from customer in this thread. They are using some gas station which supplies the correct amount of gas. But it seems that they require the SDK to not access TX.gas.
How has this been tested?
Configured the original function to generate the coins and then pass them to the new function. The feed updated correctly.