-
Notifications
You must be signed in to change notification settings - Fork 278
feat(lazer/sui): initialize #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please address my comments before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work man! No other comments than the ones Ali already gave.
public fun new_invalid(): Channel { | ||
Channel::Invalid | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these functions auto-generated or just necessary boilerplate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move has a strict object ownership model, struct/enum fields can only be directly accessed in the module where they are defined. So yeah unfortunately these boilerplate getters and setters are required to open up access to other modules
/// Get a reference to the feeds vector of the update | ||
public fun feeds(update: &Update): vector<Feed> { | ||
update.feeds | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
Summary
Initializes
pyth_lazer
contract modules and includes a rough draft of a function to parse & verify a Lazer payload based off this example.How has this been tested?