-
-
Notifications
You must be signed in to change notification settings - Fork 184
It would be cool to get rid of assert in production code #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Seems reasonable to me. I can fix / review tomorrow if @samuelcolvin accepts the request. |
I had a look at some of the assert statements and it seems to me that it might be appropriate to raise |
JonasKs
added a commit
to JonasKs/arq
that referenced
this issue
Dec 15, 2022
JonasKs
added a commit
to JonasKs/arq
that referenced
this issue
Mar 21, 2023
rossmacarthur
pushed a commit
to hunchdata/arq
that referenced
this issue
Sep 19, 2023
samuelcolvin
pushed a commit
that referenced
this issue
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I suddenly discovered that arq production code (e.g.,
connection_pool
) uses asserts.This is unsafe because of the -O, -OO options in the python interpreter https://docs.python.org/3/using/cmdline.html#cmdoption-O, as well as the PYTHONOPTIMIZE environment variable.
I might suggest using instead of:
something like this:
The text was updated successfully, but these errors were encountered: