Skip to content

Enable more Windows pytest-run-parallel CI #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

Enable more Windows pytest-run-parallel CI #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae4a8bf
enable windows pytest-run-parallel CI
ngoldbaum Aug 25, 2025
fbb6c8a
pass skip-thread-unsafe
ngoldbaum Aug 25, 2025
bf01443
remove OS conditional
ngoldbaum Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,14 +429,8 @@ jobs:
python -m pip install .

- name: run tests under pytest-run-parallel
if: runner.os == 'Windows'
run: |
python -m pytest --parallel-threads=4 src/c

- name: run tests under pytest-run-parallel
if: runner.os != 'Windows'
run: |
python -m pytest --parallel-threads=4
python -m pytest --parallel-threads=4 --skip-thread-unsafe=True

clang_TSAN:
runs-on: ubuntu-latest
Expand Down
5 changes: 5 additions & 0 deletions testing/cffi1/test_function_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import pytest, sys

pytestmark = [
pytest.mark.thread_unsafe(reason="Workers would share a build directory"),
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't needed until now because this test file only runs on Windows, see below


try:
# comment out the following line to run this test.
# the latest on x86-64 linux: https://github.com/libffi/libffi/issues/574
Expand Down
Loading