Dadjoke

[Tr-Do]

Relevant Issues

https://github.com//issues/1691?notification_referrer_id=NT_kwDOBivkC7UxODE0MTkwMjE5MjoxMDM1Mzk3MjM#event-19124053085

Description

Changes made:

• Extend the existing 'joke' command with 'dad' category using icanhazdadjoke API
• Keep the existing joke categories (chuck, neutral, all)
  How it's implemented:
• When dad joke is called, an asynchronous HTTP GET request is made to https://icanhazdadjoke.com with aiohttp
• Implement user agent to comply with icanhazdadjoke API policy
• The joke from JSON is sent back to the user with ctx.send()
• Linted and tested in a new python file before adding the code to fun.py

Did you:

• Join the Python Discord Community?
• Read all the comments in this template?
• Ensure there is an issue open, or link relevant discord discussions?
• Read and agree to the contributing guidelines?

[wookie184]

Hi, sorry for the slow review, this looks great, thank you!

I have two minor comments.

[wookie184]

• Reusing the bot's internal http_session is more efficient than creating a new one.
• Including a contact method (e.g. the URL to the project) in the user agent is good practice.

Suggested change

	async with aiohttp.ClientSession() as session, session.get(
	"https://icanhazdadjoke.com",
	headers={
	"Accept":"application/json",
	"User-Agent": "Sir-lancebot"
	}) as res:
	async with self.bot.http_session.get(
	"https://icanhazdadjoke.com",
	headers={
	"Accept": "application/json",
	"User-Agent": "Sir-Lancebot (https://github.com/python-discord/sir-lancebot)",
	}
	) as res:

[wookie184]

This path indicates something is wrong, it's probably a good idea to raise an error so it will be logged and we can look into it. res.raise_for_status() can be used to do this.

[wookie184]

Thanks!