Python 3 support #46
Python 3 support #46
Conversation
It's not clear why they're different, but I've checked them manually and they appear exactly the same.
|
👍 |
|
@cjw296 : I just wanted to make sure this hasn't fallen off the radar. The tests appear to be passing. |
|
👍 |
| @@ -1648,7 +1641,7 @@ def wordNumber(self,bit): | |||
|
|
|||
| def bitMask(self,bit): | |||
| pos = bit & BitSet.MOD_MASK ## bit mod BITS | |||
| return (1L << pos) | |||
| return (1 << pos) | |||
There was a problem hiding this comment.
Does losing the L have an impact on Py2?
There was a problem hiding this comment.
No, ints are automatically upgraded to longs if left-shifting takes them past maxint.
|
To help with this I added a PR to this PR: That adds tox and pytest support and fixes bugs in a test that wasn't being ran by nose. |
|
What is left to get this merged in? I'd love to see it :) |
Add tox and pytest support to catch additional bugs
|
With takluyver#2 I've added the badges for pypi, coveralls, and travis. We should enable coveralls on this repo to get the badge working properly. |
|
@cjw296 Beers on me at PyCon if you merge this :) 🍻 🍸 |
|
+1 |
|
I'm coming to 3 days of sprints at PyCon with the express intent of merging this. |
|
@cjw296 we were hoping to get a release prior to pycon. We just ported all our stuff to py3 and want to have it fully in prod running stable releases before pycon. Could we consider merging this to a develop/feature branch and release a prerelease version people can test out? Are there specific things in this PR you feel aren't ready that we could help with? |
|
I will be at Pycon, but I'd be happy to get this merged before then. I can think of more interesting things to be working on during the few days of sprints with Pythonistas from around the world. |
|
Hi! Any progress on this? |
|
up |
|
(btw if it helps, xlwt-future has py3 support, though beware it doesn't play will with newrelic) |
|
Woo! 🎉 ✨ 🍰 |
|
I know what they fix, the blatant lack of back doors. |
|
@nicklasb - huh? |
|
Just kidding. |
Following discussion on PR #32, this adds Python 3 support without any external dependencies. Python 2.6 and above and Python 3.3 and above should work; older versions will not.
The tests are passing on Python 2 and 3; I haven't tried the examples.