Use types_or in TOML example
#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Yes, good catch. Thanks!
I looked into some of the original discussion around types_or to see if I was missing something, but it seems like the best thing for right now is to just include examples using types_or.
I'll try to make sure that any changes to types/types_or/files and other matching goes into the changelog in the future, so that nobody sees surprises with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, just found a problem in the current TOML example for pre-commit. I've done a comparison between the current example and this solution in a separate repo:
typesthe instance files are never detected.types_orthe problem is solved.