Fix the handling of bad Last-Modified headers #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally found via an OverflowError on some Windows usage where the default Last-Modified header was used, there are several issues which were not handled correctly by the downloader. 1. OverflowError: a last mod date outside of `mktime`'s supported range causes this 2. ValueError: a malformed header causes `strptime` to fail 3. LookupError/KeyError: the header is missing (3) was previously handled by falling back to a default time which was then strptime parsed. This is now caught as a LookupError and handled with the fixed default of `0.0` used for all of these bad-parse cases. The semantics are the same, but the implementation is simpler and more uniform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally found via an OverflowError on some Windows usage where the default Last-Modified header was used, there are several issues which were not handled correctly by the downloader.
mktime's supported range causes thisstrptimeto fail(3) was previously handled by falling back to a default time which was then strptime parsed. This is now caught as a LookupError and handled with the fixed default of
0.0used for all of these bad-parse cases. The semantics are the same, but the implementation is simpler and more uniform.