oneOf array of simple types bug - propose fix

[GrahamJB1]

basicSchemaDefn = """{
'$schema':'http://json-schema.org/draft-04/schema#',
'title':'Test',
'properties':{
'SimpleArrayOfNumberOrString':{
'$ref':'#/definitions/simparray'
}
},
'required':[
'SimpleArrayOfNumberOrString'
],
'type':'object',
'definitions':{
'simparray':{
'oneOf':[
{
'type':'array',
'items':{
'type':'number'
}
},
{
'type':'array',
'items':{
'type':'string'
}
}
]
}
}
}"""

basicSchema = json.loads(basicSchemaDefn.replace(''', '"'))
builder = pjs.ObjectBuilder(basicSchema)

ns = builder.build_classes(no_extra_parameters = True)
ns.Test().from_json('{"SimpleArrayOfNumberOrString" : [0, 1]}')

---

Proposed fix in classbuilder.py validate:

elif isinstance(val, list):
if len(val) and hasattr(val[0], "validate"):
for subval in val:
subval.validate()
else:

handle basic types

setattr(self, prop, val)

[Julian]

Hi.

Not sure you have the right repo here.

If you do, can you update your description to be runnable?

Thanks!

[GrahamJB1]

Hi,
Sorry I missed the imports at the top, otherwise it is runnable. Just paste into a python script.
The failure is against your latest release.
Thanks.
Yours,
Graham

[GrahamJB1]

That is 3.0.0a3, and the title ' handle basic types above' in the proposed solution is of course a comment mangled by the wiki

[Julian]

Thanks.

What bug is being reported? And what's pjs.ObjectBuilder, that's not an object defined in this repo.

[GrahamJB1]

I am deeply sorry - you are quite right, I am using 3.0.0a3 in conjunction with python jsonschema object and the bug is in their library. Many thanks for your prompt reply, and thank you for the high quality of your library !

[Julian]

No worries, and thank you!

…

On Mon, Oct 8, 2018, 19:35 GrahamJB1 ***@***.***> wrote: Closed #476 <#476>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#476 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUIXqaXeeggOJGKoIYigirAN3XmDwZ-ks5ui-FOgaJpZM4XNJy5> .