Skip to content

4.2.0 contains versionless dep on importlib_resources #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eddie-scio opened this issue Nov 4, 2021 · 1 comment · Fixed by #877
Closed

4.2.0 contains versionless dep on importlib_resources #876

eddie-scio opened this issue Nov 4, 2021 · 1 comment · Fixed by #877

Comments

@eddie-scio
Copy link

Could we add version boundaries here like we do for other libraries? Older versions (e.g. 1.0.2) of importlib_resources (if pinned) will throw errors like below

  File "/env/lib/python3.7/site-packages/jsonschema/__init__.py", line 29, in <module> 
    from jsonschema.validators import ( 
  File "/env/lib/python3.7/site-packages/jsonschema/validators.py", line 349, in <module> 
    meta_schema=_utils.load_schema("draft3"), 
  File "/env/lib/python3.7/site-packages/jsonschema/_utils.py", line 60, in load_schema 
    path = resources.files(__package__).joinpath(f"schemas/{name}.json") 
AttributeError: module 'importlib_resources' has no attribute 'files' 
@Julian
Copy link
Member

Julian commented Nov 4, 2021

Sure, happy to see a PR pinning importlib-resources from below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants