Skip to content

Add version constraint to importlib_resources #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Nov 5, 2021

Based on this recent change in the docs I opted to require importlib_resources>=1.4.0, but tests also passed in jsonschema when using importlib_resources v1.1.0.

Let me know if you want to use importlib_resources>=1.1.0 instead.

For reference: https://importlib-resources.readthedocs.io/en/latest/history.html.

Fixes #876.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #877 (f8d18fa) into main (3d2eec2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          19       19           
  Lines        3125     3125           
  Branches      378      378           
=======================================
  Hits         3073     3073           
  Misses         41       41           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2eec2...f8d18fa. Read the comment docs.

@Julian
Copy link
Member

Julian commented Nov 5, 2021

Thanks.

@Julian Julian merged commit 1499972 into python-jsonschema:main Nov 5, 2021
@sevein sevein deleted the dev/issue-876-importlib-resources-constraint branch November 5, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.2.0 contains versionless dep on importlib_resources
2 participants