Fix bug in current registration of validators and address #417 #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to #417 (fixes #417)
Currently, the validator registration is hardcoded to use the deprecated "id" keyword, rather than using the new "id_of" function passed to
create
. This means that only draft 3 and 4 are currently registered. This is not visibly a bug at present, because there is only one other schema, and the fallback mechanism selects the most recent. However, for good practice we should still register the draft 6 schema.This PR adds a
Validator.ID_OF
staticmethod, and call it from the registrar.