jsonschema: Fix non http/https url RefResolution exception #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using file:///schema-dir-name URLs we are hitting AttributeError exception during refresolution. Reason for it is, there isn't any context manager implemented for urlopen (i.e. it doesn't have __enter__ and __exit__ methods defined). This patch fixes this issue. Signed-off-by: Kuppuswamy Sathyanarayanan <[email protected]>
|
This is a bug introduced by #427, which was just merged. I was unhappy with the test submitted, but didn't have enough time to fully fix it or explain to the submitter why :/ That'll teach me I suppose. The test here needs to be a "normal" test, no mocking (#335). The correct implementation of this likely will use Would you be able to try writing one? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using file:///schema-dir-name URLs we are hitting AttributeError
exception during refresolution. Reason for it is, there isn't any
context manager implemented for urlopen (i.e. it doesn't have
enter and exit methods defined).
This patch fixes this issue.
Signed-off-by: Kuppuswamy Sathyanarayanan [email protected]