Skip to content

Prevent showing cmd on Windows and add handling for ruff execution with pythonw #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Prevent showing cmd on Windows and add handling for ruff execution with pythonw #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c84958
Prevent showing cmd on Windows and add handling for ruff execution wi…
dalthviz Sep 25, 2025
4968caa
Handle CREATE_NO_WINDOW subprocess flag value (only available on Wind…
dalthviz Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ __pycache__/
*.swp
tags
/build/

.spyproject/
11 changes: 9 additions & 2 deletions pylsp_ruff/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@
from subprocess import PIPE, Popen
from typing import Dict, Generator, List, Optional

if sys.platform == "win32":
from subprocess import CREATE_NO_WINDOW
else:
# CREATE_NO_WINDOW flag only available on Windows.
# Set constant as default `Popen` `creationflag` kwarg value (`0`)
CREATE_NO_WINDOW = 0

if sys.version_info >= (3, 11):
import tomllib
else:
Expand Down Expand Up @@ -502,7 +509,7 @@ def find_executable(executable) -> List[str]:
# try the python module
if cmd is None:
if importlib.util.find_spec("ruff") is not None:
cmd = [sys.executable, "-m", "ruff"]
cmd = [sys.executable.replace("pythonw", "python"), "-m", "ruff"]

# try system's ruff executable
if cmd is None:
Expand Down Expand Up @@ -557,7 +564,7 @@ def run_ruff(
cmd = [*find_executable(executable), str(subcommand), *arguments]

log.debug(f"Calling {cmd} on '{document_path}'")
p = Popen(cmd, stdin=PIPE, stdout=PIPE)
p = Popen(cmd, stdin=PIPE, stdout=PIPE, creationflags=CREATE_NO_WINDOW)
(stdout, _) = p.communicate(document_source.encode())

if p.returncode != 0:
Expand Down