-
-
Notifications
You must be signed in to change notification settings - Fork 32
Switch to a MIT-licensed dependency #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to a MIT-licensed dependency #4
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
+ Coverage 58.38% 59.89% +1.50%
==========================================
Files 6 6
Lines 173 182 +9
==========================================
+ Hits 101 109 +8
- Misses 72 73 +1
Continue to review full report at Codecov.
|
@p1c2u Is there a reason for not merging this? |
Bumping this. Under the terms of the GPLv3 license, Is there anything else you'd like to see here before this gets merged @p1c2u? |
@arrdem not sure about your use case but I jest went with https://github.com/Julian/jsonschema and it did work for my needs. |
@RafalSkolasinski yeah I was able to bang out a tiny bit of code that solved my actual problem just using jsonschema directly yesterday. Oh well. |
Looks like this could do with a rebase to resolve the conflicts. |
@AaronRobson, thanks for approving this PR. I've resolved the merge conflict, please consider merging it. |
Would if I could, sadly I don't have permissions for that. |
Right, my apologies, I was under the impression that only members with Write permissions can review PRs in this repo. |
Why not use both as an option |
c048404
to
48ffd98
Compare
Openapi-schema-validator was using a GPL-licensed library strict_rfc3339, which might be incompatible with BSD. This pull request replaces strict_rfc3339 library with a different one - rfc3339_validator. This library is licensed under MIT.
Jsonschema library has already been updated to include an option to use a different RFC3339 checker by this Pull Request.