Skip to content

Switch to a MIT-licensed dependency #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2021

Conversation

DaniilGlazkoTR
Copy link
Contributor

Openapi-schema-validator was using a GPL-licensed library strict_rfc3339, which might be incompatible with BSD. This pull request replaces strict_rfc3339 library with a different one - rfc3339_validator. This library is licensed under MIT.

Jsonschema library has already been updated to include an option to use a different RFC3339 checker by this Pull Request.

@DaniilGlazkoTR DaniilGlazkoTR changed the title Switch to a MIL-licensed dependency Switch to a MIT-licensed dependency Mar 18, 2020
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #4 (48ffd98) into master (c86b093) will increase coverage by 1.50%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   58.38%   59.89%   +1.50%     
==========================================
  Files           6        6              
  Lines         173      182       +9     
==========================================
+ Hits          101      109       +8     
- Misses         72       73       +1     
Impacted Files Coverage Δ
openapi_schema_validator/_format.py 65.88% <77.77%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86b093...48ffd98. Read the comment docs.

@RafalSkolasinski
Copy link

@p1c2u Is there a reason for not merging this?

@arrdem
Copy link

arrdem commented Oct 29, 2020

Bumping this. Under the terms of the GPLv3 license, openapi-schema-validator and its dependees cannot be distributed or used under MIT terms because of this single dependency.

Is there anything else you'd like to see here before this gets merged @p1c2u?

@RafalSkolasinski
Copy link

@arrdem not sure about your use case but I jest went with https://github.com/Julian/jsonschema and it did work for my needs.
Taking into account that there were no commits and barely any activity in this repo in last 8 months probably it was a right decision

@arrdem
Copy link

arrdem commented Oct 30, 2020

@RafalSkolasinski yeah I was able to bang out a tiny bit of code that solved my actual problem just using jsonschema directly yesterday. Oh well.

@AaronRobson
Copy link

Looks like this could do with a rebase to resolve the conflicts.

@DaniilGlazkoTR
Copy link
Contributor Author

@AaronRobson, thanks for approving this PR. I've resolved the merge conflict, please consider merging it.

@AaronRobson
Copy link

@AaronRobson, thanks for approving this PR. I've resolved the merge conflict, please consider merging it.

Would if I could, sadly I don't have permissions for that.

@DaniilGlazkoTR
Copy link
Contributor Author

@AaronRobson, thanks for approving this PR. I've resolved the merge conflict, please consider merging it.

Would if I could, sadly I don't have permissions for that.

Right, my apologies, I was under the impression that only members with Write permissions can review PRs in this repo.

@p1c2u
Copy link
Collaborator

p1c2u commented Feb 27, 2021

Why not use both as an option

@p1c2u p1c2u force-pushed the feature/licensing branch from c048404 to 48ffd98 Compare February 27, 2021 15:05
@p1c2u p1c2u merged commit 8c34462 into python-openapi:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants