Add reproducer for #20

README.rst

@@ -18,7 +18,7 @@ openapi-schema-validator
 About
 #####
 
-Openapi-schema-validator is a Python library that validates schema against:
+*openapi-schema-validator* is a Python library that validates schema against:
 
 * `OpenAPI Schema Specification v3.0 <https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#schemaObject>`__ which is an extended subset of the `JSON Schema Specification Wright Draft 00 <http://json-schema.org/>`__.
 * `OpenAPI Schema Specification v3.1 <https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.1.0.md#schemaObject>`__ which is an extended superset of the `JSON Schema Specification Draft 2020-12 <http://json-schema.org/>`__.
@@ -38,7 +38,6 @@ Alternatively you can download the code and install from the repository:
 
    $ pip install -e git+https://github.com/p1c2u/openapi-schema-validator.git#egg=openapi_schema_validator
 
-
 Usage
 #####
 
@@ -92,7 +91,7 @@ To validate an OpenAPI v3.1 schema:
        ...
    ValidationError: Additional properties are not allowed ('city' was unexpected)
 
-if you want to disambiguate the expected schema version, import and use ``OAS31Validator``:
+If you want to disambiguate the expected schema version, import and use ``OAS31Validator``:
 
 .. code-block:: python
 
@@ -150,7 +149,7 @@ You can also check format for primitive types
 References
 **********
 
-You can resolve JOSN references by passing custon reference resolver
+You can resolve JSON references by passing custom reference resolver
 
 .. code-block:: python
 
@@ -204,6 +203,7 @@ For more information about reference resolver see `Resolving JSON References <ht
 
 Related projects
 ################
+
 * `openapi-core <https://github.com/p1c2u/openapi-core>`__
    Python library that adds client-side and server-side support for the OpenAPI.
 * `openapi-spec-validator <https://github.com/p1c2u/openapi-spec-validator>`__

tests/integration/test_validators.py

@@ -21,10 +21,13 @@ class TestOAS30ValidatorValidate:
             "integer",
             "number",
             "string",
+            "object",
         ],
     )
     def test_null(self, schema_type):
         schema = {"type": schema_type}
+        if schema_type == "object":
+            schema["properties"] = {"some_prop": {"type": "string"}}
         validator = OAS30Validator(schema)
         value = None
 
@@ -39,10 +42,13 @@ def test_null(self, schema_type):
             "integer",
             "number",
             "string",
+            "object",
         ],
     )
     def test_nullable(self, schema_type):
         schema = {"type": schema_type, "nullable": True}
+        if schema_type == "object":
+            schema["properties"] = {"some_prop": {"type": "string"}}
         validator = OAS30Validator(schema)
         value = None
 
@@ -195,6 +201,54 @@ def test_string_uuid(self, value):
 
         assert result is None
 
+    def test_ref(self):
+        schema = {
+            "$ref": "#/$defs/Pet",
+            "$defs": {
+                "Pet": {
+                    "required": ["id", "name"],
+                    "properties": {
+                        "id": {"type": "integer", "format": "int64"},
+                        "name": {"type": "string"},
+                        "tag": {"type": "string"},
+                    },
+                }
+            },
+        }
+        validator = OAS30Validator(schema, format_checker=oas30_format_checker)
+
+        result = validator.validate({"id": 1, "name": "John"})
+        assert result is None
+
+        with pytest.raises(ValidationError) as excinfo:
+            validator.validate({"name": "John"})
+
+        error = "'id' is a required property"
+        assert error in str(excinfo.value)
+
+    @pytest.mark.xfail(reason="Issue #20")
+    def test_ref_nullable(self):
+        schema = {
+            "nullable": True,
+            "allOf": [
+                {
+                    "$ref": "#/$defs/Pet",
+                },
+            ],
+            "$defs": {
+                "Pet": {
+                    "required": ["id", "name"],
+                    "properties": {
+                        "id": {"type": "integer", "format": "int64"},
+                        "name": {"type": "string"},
+                        "tag": {"type": "string"},
+                    },
+                }
+            },
+        }
+        validator = OAS30Validator(schema, format_checker=oas30_format_checker)
+        validator.validate(None)
+
     def test_allof_required(self):
         schema = {
             "allOf": [
@@ -211,6 +265,20 @@ def test_allof_required(self):
         ):
             validator.validate({"another_prop": "bla"})
 
+    @pytest.mark.xfail(reason="Issue #20")
+    def test_allof_nullable(self):
+        schema = {
+            "allOf": [
+                {
+                    "type": "object",
+                    "properties": {"some_prop": {"type": "string"}},
+                },
+                {"type": "object", "nullable": True},
+            ]
+        }
+        validator = OAS30Validator(schema, format_checker=oas30_format_checker)
+        validator.validate(None)
+
     def test_required(self):
         schema = {
             "type": "object",
@@ -439,7 +507,7 @@ def test_oneof_discriminator(self, schema_type):
             ValidationError,
             match="reference '#/components/schemas/other' could not be resolved",
         ):
-            result = validator.validate({"discipline": "other"})
+            validator.validate({"discipline": "other"})
             assert False
 
 
@@ -452,10 +520,13 @@ class TestOAS31ValidatorValidate:
             "integer",
             "number",
             "string",
+            "object",
         ],
     )
     def test_null(self, schema_type):
         schema = {"type": schema_type}
+        if schema_type == "object":
+            schema["properties"] = {"some_prop": {"type": "string"}}
         validator = OAS31Validator(schema)
         value = None
 
@@ -470,10 +541,13 @@ def test_null(self, schema_type):
             "integer",
             "number",
             "string",
+            "object",
         ],
     )
     def test_nullable(self, schema_type):
         schema = {"type": [schema_type, "null"]}
+        if schema_type == "object":
+            schema["properties"] = {"some_prop": {"type": "string"}}
         validator = OAS31Validator(schema)
         value = None
 
@@ -653,7 +727,7 @@ def test_schema_validation(self):
         error = "'-12' is not a 'date'"
         assert error in str(excinfo.value)
 
-    def test_schema_ref(self):
+    def test_ref(self):
         schema = {
             "$ref": "#/$defs/Pet",
             "$defs": {
@@ -681,6 +755,28 @@ def test_schema_ref(self):
         error = "'id' is a required property"
         assert error in str(excinfo.value)
 
+    def test_ref_nullable(self):
+        # specifying an array for type only works with primitive types
+        schema = {
+            "oneOf": [
+                {"type": "null"},
+                {"$ref": "#/$defs/Pet"},
+            ],
+            "$defs": {
+                "Pet": {
+                    "type": "object",
+                    "required": ["id", "name"],
+                    "properties": {
+                        "id": {"type": "integer", "format": "int64"},
+                        "name": {"type": "string"},
+                        "tag": {"type": "string"},
+                    },
+                }
+            },
+        }
+        validator = OAS31Validator(schema, format_checker=oas30_format_checker)
+        validator.validate(None)
+
     @pytest.mark.parametrize(
         "value",
         [

tox.ini

@@ -0,0 +1,11 @@
+[tox]
+minversion = 3.18.0
+requires = tox-poetry
+
+[testenv]
+extras =
+  rfc3339-validator
+  strict-rfc3339
+  isodate
+commands =
+  pytest {posargs:tests/}