Skip to content

disable required properties checks in allOf blocks #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dtkav
Copy link
Contributor

@dtkav dtkav commented Jun 20, 2018

@dtkav dtkav changed the title WIP: disable required properties checks in allOf blocks disable required properties checks in allOf blocks Jun 20, 2018
@dtkav dtkav force-pushed the allow_lone_required_block_in_allOf branch from 49c7d75 to eb82d74 Compare June 20, 2018 04:16
@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #28 into master will increase coverage by 3.53%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage    94.1%   97.64%   +3.53%     
==========================================
  Files          11       11              
  Lines         339      339              
==========================================
+ Hits          319      331      +12     
+ Misses         20        8      -12
Impacted Files Coverage Δ
openapi_spec_validator/validators.py 97.43% <100%> (+3.84%) ⬆️
openapi_spec_validator/managers.py 94.73% <0%> (+31.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f5452...eb82d74. Read the comment docs.

@p1c2u
Copy link
Collaborator

p1c2u commented Jun 21, 2018

@dtkav thanks for the contribution. LGTM

Fixes ##27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants