Skip to content

Fix LCMS2 patch #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2020
Merged

Fix LCMS2 patch #4858

merged 2 commits into from
Aug 13, 2020

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Aug 12, 2020

Fixes error from #4857:

had to modify winbuild\build\lcms2-2.11\Projects\VC2017\lcms2_static\lcms2_static.vcxproj to point to the installed windows SDK version (10.0.19041.0) for it to compile, but otherwise, everything worked fine

Also make sure all patches are actually applied to avoid this happening again.

@nulano nulano mentioned this pull request Aug 12, 2020
Closed
@nulano
Copy link
Contributor Author

nulano commented Aug 12, 2020

GHA 3.9-dev jobs have now started failing due to #4784 with the release of 3.9-rc1.

@nulano nulano mentioned this pull request Aug 12, 2020
Merged
@hugovk hugovk merged commit a34cc1d into python-pillow:master Aug 13, 2020
@hugovk
Copy link
Member

hugovk commented Aug 13, 2020

thanks!

@nulano nulano deleted the winbuild-lcms2 branch August 13, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nulano @hugovk