Skip to content

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Nov 27, 2023

Improvements to tests, including removal of _assert_raises, pulled out from #2886

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2890 (b9acf48) into master (9c496fa) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2890      +/-   ##
==========================================
- Coverage   99.54%   99.54%   -0.01%     
==========================================
  Files         115      115              
  Lines       17660    17623      -37     
  Branches     3165     3153      -12     
==========================================
- Hits        17580    17543      -37     
  Misses         52       52              
  Partials       28       28              
Files Coverage Δ
src/trio/_core/_tests/test_run.py 100.00% <100.00%> (ø)
src/trio/_tests/test_ssl.py 99.85% <100.00%> (-0.01%) ⬇️
src/trio/_tests/test_util.py 100.00% <100.00%> (ø)
src/trio/testing/_check_streams.py 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@jakkdl
Copy link
Member Author

jakkdl commented Nov 28, 2023

The coverage change is from mypy stuff in test_exports, idk why it's popping up here but should probably get some pragma: no cover in another PR.

@jakkdl jakkdl requested review from A5rocks and Zac-HD November 28, 2023 15:37
Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@Zac-HD Zac-HD merged commit 592718b into python-trio:master Nov 28, 2023
@jakkdl jakkdl deleted the test_improvements branch November 28, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants