-
Notifications
You must be signed in to change notification settings - Fork 0
Add section on HTTP/2 features, including push. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lukasa
wants to merge
1
commit into
master
Choose a base branch
from
http2-features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure how the "preload" spec is related to the server... The server has not access to the "link" information, it's rather an hint for the client that may be sent via the link header or not to the server. However, we need to introduce a way to tell to the application it can place such events on the server that support it.
Something like
where stream would be a fileobject like.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sever does have access to the Link information in the only way that matters.
HTTP/2 push works by constructing a "fake" request that is used to correlate with a single response. The way this would work in this case is that that application would send the Link header, which the server would catch. The server would generate this fake request, send it back to the application, then push the application's response.
Let me sketch this out below:
The server receives the following request and passes it to the application in the standard WSGI manner (needing to construct the WSGI environ dict and so on):
The application sends a 200 response that contains the header
Link: </static/style.css>; rel=preload; as=style
.The server catches that header. It supports HTTP/2 server push by this extension, and so it immediately generates a new "fake" request for that resource, which looks like this:
The server then does two things with this virtual request. Firstly, it pushes it to the client in a PUSH_PROMISE frame. Secondly, it sends it to the application exactly like it received it from the real client: in a brand new WSGI function call.
The application responds as normal to the new request, despite the fact that this request was actually initiated by the server.
In this model, the complexities of pushing resources are handled entirely within the server. This allows for some neat optimisations: for example, servers that can be both WSGI servers and serve static files (such as Apache) can potentially run the pushed request through their complete request routing logic, allowing for the application to push static files directly. It also allows us to maintain the standard WSGI interface while opening the possibility for the application to provide push hints to the server.
Finally, the push hint here is also of use to the client in the case where pushing is not possible. Servers that do not opt in or do not support HTTP/2 still function correctly, and clients behave as expected.
Does that make sense?