Skip to content

Define REQUEST_URI environ variable. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Define REQUEST_URI environ variable. #5

wants to merge 4 commits into from

Conversation

Lukasa
Copy link
Contributor

@Lukasa Lukasa commented Feb 17, 2016

This defines the REQUEST_URI variable, which is used to provide the full, un-normalized request URI.

@andrewgodwin
Copy link

This needs the string-type specified (I presume "native", since that's the compromise we need to work with)

@Lukasa
Copy link
Contributor Author

Lukasa commented Feb 17, 2016

Ok, both changes have been made here.

@cdent
Copy link

cdent commented Feb 17, 2016

Yes please!

@benoitc
Copy link

benoitc commented Feb 24, 2016

who is using REQUEST_URI in python world, versus the RAW_URI in gunicorn though?

@benoitc
Copy link

benoitc commented Feb 24, 2016

this seems nitpicking but the reason I ask is for the clarity of the variable name. If we want to explicitly state that this the raw uri then why not calling it that way?

@cdent
Copy link

cdent commented Feb 24, 2016

I know that at least cherrypy makes REQUEST_URI available and I'm pretty sure that modwsgi does as well, whereas as far as I'm aware only gunicorn uses RAW_URI. In my own wsgi services I check for REQUEST_URI first and then RAW_URI. It would be great if it were just one.

@benoitc
Copy link

benoitc commented Feb 24, 2016

fair enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants