Skip to content

'awaiting merge' label gets applied even if PR is closed #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lysnikolaou opened this issue Oct 31, 2020 · 1 comment · Fixed by #292
Closed

'awaiting merge' label gets applied even if PR is closed #291

lysnikolaou opened this issue Oct 31, 2020 · 1 comment · Fixed by #292

Comments

@lysnikolaou
Copy link
Member

Example: python/cpython#23065.
@lysnikolaou
Copy link
Member Author

I'll quickly fix this later tonight, if we feel it's worth it.

lysnikolaou added a commit to lysnikolaou/bedevere that referenced this issue Oct 31, 2020
@lysnikolaou
Do not apply the 'awaiting merge' label on a closed PR
4d8cce3 
If an approval comes after the PR has been merged, bedevere still
applies the `awaiting merge` label, which might cause confusion
when searching for PRs with that label.

Fixes python#291.
@lysnikolaou lysnikolaou mentioned this issue Oct 31, 2020
Merged
lysnikolaou added a commit that referenced this issue Nov 2, 2020
@lysnikolaou
Do not apply the 'awaiting merge' label on a closed PR (#292)
5edc7d1 
If an approval comes after the PR has been merged, bedevere still
applies the `awaiting merge` label, which might cause confusion
when searching for PRs with that label.

Fixes #291.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not apply the 'awaiting merge' label on a closed PR lysnikolaou/bedevere
1 participant
@lysnikolaou