Skip to content

3.10 MSI no longer built with VS2022 after #101651 #101875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
w-hsiung opened this issue Feb 13, 2023 · 2 comments
Closed

3.10 MSI no longer built with VS2022 after #101651 #101875

w-hsiung opened this issue Feb 13, 2023 · 2 comments
Labels
build The build process and cross-build OS-windows topic-installation type-bug An unexpected behavior, bug, or error

Comments

@w-hsiung
Copy link

Bug report

3.10 MSI no longer builds after #101651 .

Possibly a new entry for 'v143' is missing in https://github.com/python/cpython/blob/3.10/Tools/msi/bundle/bootstrap/pythonba.vcxproj
(at around line 52).

@w-hsiung w-hsiung added the type-bug An unexpected behavior, bug, or error label Feb 13, 2023
@arhadthedev arhadthedev added build The build process and cross-build topic-installation labels Feb 13, 2023
@adang1345
Copy link
Contributor

I'm seeing this error as well when attempting to build a Python 3.10.11 installer on Windows with Visual Studio 2022. Here's the error when I run Tools\msi\buildrelease.bat -x86.

BuildBootstrapApplication:
  Building bootstrap app
Project "C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\Tools\msi\bundle\releaselocal.wixproj" (1) is building "C:
\Users\adang\Desktop\PythonWindows\Python-3.10.11\Tools\msi\bundle\bootstrap\pythonba.vcxproj" (24) on node 1 (Build;Ge
tNativeTargetPath target(s)).
PrepareForBuild:
  Creating directory "C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Release\msi_pythonba\".
  Creating directory "C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Release\msi_pythonba\pyt
  honba.tlog\".
InitializeBuildStatus:
  Creating "C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Release\msi_pythonba\pythonba.tlog
  \unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
  C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.35.32215\bin\HostX86\x86\CL.exe /c /I"C:\Use
  rs\adang\Desktop\PythonWindows\Python-3.10.11\externals\\windows-installer\wix\sdk\inc" /Zi /nologo /W1 /WX- /diagnos
  tics:column /O2 /Oy- /D _CRT_STDIO_LEGACY_WIDE_SPECIFIERS=1 /D _WINDLL /D _UNICODE /D UNICODE /Gm- /EHsc /MT /GS /fp:
  precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yc"pch.h" /Fp"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuil
  d\obj\310win32_Release\msi_pythonba\PythonBA.pch" /Fo"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj
  \310win32_Release\msi_pythonba\\" /Fd"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Releas
  e\msi_pythonba\vc143.pdb" /external:W1 /Gd /TP /analyze- /FC /errorReport:queue pch.cpp
  pch.cpp
  C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.35.32215\bin\HostX86\x86\CL.exe /c /I"C:\Use
  rs\adang\Desktop\PythonWindows\Python-3.10.11\externals\\windows-installer\wix\sdk\inc" /Zi /nologo /W1 /WX- /diagnos
  tics:column /O2 /Oy- /D _CRT_STDIO_LEGACY_WIDE_SPECIFIERS=1 /D _WINDLL /D _UNICODE /D UNICODE /Gm- /EHsc /MT /GS /fp:
  precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yu"pch.h" /Fp"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuil
  d\obj\310win32_Release\msi_pythonba\PythonBA.pch" /Fo"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj
  \310win32_Release\msi_pythonba\\" /Fd"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Releas
  e\msi_pythonba\vc143.pdb" /external:W1 /Gd /TP /analyze- /FC /errorReport:queue PythonBootstrapperApplication.cpp pyt
  honba.cpp
  PythonBootstrapperApplication.cpp
  pythonba.cpp
  Generating Code...
Link:
  C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.35.32215\bin\HostX86\x86\link.exe /ERRORREPO
  RT:QUEUE /OUT:"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Release\msi_pythonba\PythonBA
  .dll" /NOLOGO comctl32.lib gdiplus.lib msimg32.lib shlwapi.lib wininet.lib dutil.lib balutil.lib version.lib uxtheme.
  lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.
  lib odbc32.lib odbccp32.lib /DEF:"pythonba.def" /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest
  :embed /DEBUG:FULL /PDB:"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Release\msi_pythonb
  a\PythonBA.pdb" /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\
  obj\310win32_Release\msi_pythonba\PythonBA.lib" /MACHINE:X86 /SAFESEH /DLL "C:\Users\adang\Desktop\PythonWindows\Pyth
  on-3.10.11\PCbuild\obj\310win32_Release\msi_pythonba\PythonBootstrapperApplication.obj"
  "C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Release\msi_pythonba\pythonba.obj"
  "C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\PCbuild\obj\310win32_Release\msi_pythonba\pch.obj"
LINK : fatal error LNK1104: cannot open file 'dutil.lib' [C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\Tools\msi
\bundle\bootstrap\pythonba.vcxproj]
Done Building Project "C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\Tools\msi\bundle\bootstrap\pythonba.vcxproj"
 (Build;GetNativeTargetPath target(s)) -- FAILED.

Done Building Project "C:\Users\adang\Desktop\PythonWindows\Python-3.10.11\Tools\msi\bundle\releaselocal.wixproj" (Rebu
ild target(s)) -- FAILED.


Build FAILED.

Adding the following line to Tools/msi/bundle/bootstrap/pythonba.vcxproj appears to fix the problem.

<AdditionalLibraryDirectories Condition="'$(PlatformToolset)' == 'v143'">$(WixInstallPath)sdk\vs2017\lib\x86</AdditionalLibraryDirectories>

@adang1345
Copy link
Contributor

It looks like this was fixed with #103281.

@w-hsiung w-hsiung closed this as completed Apr 6, 2023
liudonghua123 added a commit to liudonghua123/windows-python-installer that referenced this issue Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-windows topic-installation type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants