Skip to content

gc.freeze documentation is unclear #103059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
raylu opened this issue Mar 27, 2023 · 1 comment
Closed

gc.freeze documentation is unclear #103059

raylu opened this issue Mar 27, 2023 · 1 comment
Labels
docs Documentation in the Doc dir

Comments

@raylu
Copy link
Contributor

raylu commented Mar 27, 2023 •
edited by bedevere-bot
Loading

Documentation

The current advice seems to mean you should gc.disable() and gc.freeze() right before os.fork(), which doesn't do anything.

Łukasz explained the advice in https://bugs.python.org/issue31558#msg302780.

I'm proposing a fix in PR #103058.

Linked PRs
@raylu raylu added the docs Documentation in the Doc dir label Mar 27, 2023
raylu added a commit to raylu/cpython that referenced this issue Mar 27, 2023
@raylu
pythongh-103059: Move fork advice from gc.freeze to gc.disable
183b577 
The current advice seems to mean you should gc.disable() and gc.freeze()
right before os.fork(), which doesn't do anything.

Łukasz explained the advice in
https://bugs.python.org/issue31558#msg302780.

This moves the advice around gc.disable out of the gc.freeze docs.
@bedevere-bot bedevere-bot mentioned this issue Mar 27, 2023
Merged
raylu added a commit to raylu/cpython that referenced this issue Mar 27, 2023
@raylu
pythongh-103059: Move fork advice from gc.freeze to gc.disable
d0baebf 
The current advice seems to mean you should gc.disable() and gc.freeze()
right before os.fork(), which doesn't do anything.

Łukasz explained the advice in
https://bugs.python.org/issue31558#msg302780.

This moves the advice around gc.disable out of the gc.freeze docs.
raylu added a commit to raylu/cpython that referenced this issue Mar 29, 2023
@raylu
pythongh-103059: Move fork advice from gc.freeze to gc.disable
faee1cf 
The current advice seems to mean you should gc.disable() and gc.freeze()
right before os.fork(), which doesn't do anything.

Łukasz explained the advice in
https://bugs.python.org/issue31558#msg302780.

This moves the advice around gc.disable out of the gc.freeze docs.
@arhadthedev
Copy link
Member

@pitrou, @pablogsal (as gc experts)

carljm pushed a commit that referenced this issue Apr 10, 2023
@raylu
gh-103059: Clarify gc.freeze documentation (#103058)
8b1b171
@bedevere-bot bedevere-bot mentioned this issue Apr 10, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 10, 2023
@raylu @miss-islington
pythongh-103059: Clarify gc.freeze documentation (pythonGH-103058)
51491ca 
(cherry picked from commit 8b1b171)

Co-authored-by: raylu <[email protected]>
carljm pushed a commit that referenced this issue Apr 10, 2023
@miss-islington @raylu
[3.11] gh-103059: Clarify gc.freeze documentation (GH-103058) (#103416)
b80e4c8 
gh-103059: Clarify gc.freeze documentation (GH-103058)
(cherry picked from commit 8b1b171)

Co-authored-by: raylu <[email protected]>
@carljm carljm closed this as completed Apr 10, 2023
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@raylu @warsaw
pythongh-103059: Clarify gc.freeze documentation (python#103058)
f14f2be
aisk pushed a commit to aisk/cpython that referenced this issue Apr 18, 2023
@raylu @aisk
pythongh-103059: Clarify gc.freeze documentation (python#103058)
fe82d9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carljm @raylu @arhadthedev